Skip to content
  • Andrew Morton's avatar
    [PATCH] highest_possible_node_id() linkage fix · 6220ec78
    Andrew Morton authored
    
    
    Qooting Adrian:
    
    - net/sunrpc/svc.c uses highest_possible_node_id()
    
    - include/linux/nodemask.h says highest_possible_node_id() is
      out-of-line #if MAX_NUMNODES > 1
    
    - the out-of-line highest_possible_node_id() is in lib/cpumask.c
    
    - lib/Makefile: lib-$(CONFIG_SMP) += cpumask.o
      CONFIG_ARCH_DISCONTIGMEM_ENABLE=y, CONFIG_SMP=n, CONFIG_SUNRPC=y
    
    -> highest_possible_node_id() is used in net/sunrpc/svc.c
       CONFIG_NODES_SHIFT defined and > 0
    
    -> include/linux/numa.h: MAX_NUMNODES > 1
    
    -> compile error
    
    The bug is not present on architectures where ARCH_DISCONTIGMEM_ENABLE
    depends on NUMA (but m32r isn't the only affected architecture).
    
    So move the function into page_alloc.c
    
    Cc: Adrian Bunk <bunk@stusta.de>
    Cc: Paul Jackson <pj@sgi.com>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    6220ec78