Commit 4de43726 authored by Ard Biesheuvel's avatar Ard Biesheuvel Committed by Herbert Xu

crypto: chacha20 - fix handling of chunked input

Commit 9ae433bc ("crypto: chacha20 - convert generic and x86 versions
to skcipher") ported the existing chacha20 code to use the new skcipher
API, and introduced a bug along the way. Unfortunately, the tcrypt tests
did not catch the error, and it was only found recently by Tobias.

Stefan kindly diagnosed the error, and proposed a fix which is similar
to the one below, with the exception that 'walk.stride' is used rather
than the hardcoded block size. This does not actually matter in this
case, but it's a better example of how to use the skcipher walk API.

Fixes: 9ae433bc ("crypto: chacha20 - convert generic and x86 ...")
Cc: <> # v4.11+
Cc: Steffen Klassert <>
Reported-by: default avatarTobias Brunner <>
Signed-off-by: default avatarArd Biesheuvel <>
Signed-off-by: default avatarHerbert Xu <>
parent dea3eb8b
...@@ -91,9 +91,14 @@ int crypto_chacha20_crypt(struct skcipher_request *req) ...@@ -91,9 +91,14 @@ int crypto_chacha20_crypt(struct skcipher_request *req)
crypto_chacha20_init(state, ctx, walk.iv); crypto_chacha20_init(state, ctx, walk.iv);
while (walk.nbytes > 0) { while (walk.nbytes > 0) {
unsigned int nbytes = walk.nbytes;
if (nbytes <
nbytes = round_down(nbytes, walk.stride);
chacha20_docrypt(state, walk.dst.virt.addr, walk.src.virt.addr, chacha20_docrypt(state, walk.dst.virt.addr, walk.src.virt.addr,
walk.nbytes); nbytes);
err = skcipher_walk_done(&walk, 0); err = skcipher_walk_done(&walk, walk.nbytes - nbytes);
} }
return err; return err;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment