Commit b2a1d271 authored by Markus Elfring's avatar Markus Elfring Committed by Herbert Xu

hwrng: n2 - Use devm_kcalloc() in n2rng_probe()

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "devm_kcalloc".

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.
Signed-off-by: default avatarMarkus Elfring <>
Acked-by: default avatarShannon Nelson <>
Signed-off-by: default avatarHerbert Xu <>
parent ec1bca94
......@@ -748,9 +748,7 @@ static int n2rng_probe(struct platform_device *op)
dev_info(&op->dev, "Registered RNG HVAPI major %lu minor %lu\n",
np->hvapi_major, np->hvapi_minor);
np->units = devm_kzalloc(&op->dev,
sizeof(struct n2rng_unit) * np->num_units,
np->units = devm_kcalloc(&op->dev, np->num_units, sizeof(*np->units),
err = -ENOMEM;
if (!np->units)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment