Commit b9627a21 authored by Phil Elwell's avatar Phil Elwell Committed by Greg Kroah-Hartman
Browse files

lan78xx: Don't reset the interface on open

[ Upstream commit 47b99865 ]

Commit 92571a1a ("lan78xx: Connect phy early") moves the PHY
initialisation into lan78xx_probe, but lan78xx_open subsequently calls
lan78xx_reset. As well as forcing a second round of link negotiation,
this reset frequently prevents the phy interrupt from being generated
(even though the link is up), rendering the interface unusable.

Fix this issue by removing the lan78xx_reset call from lan78xx_open.

Fixes: 92571a1a

 ("lan78xx: Connect phy early")
Signed-off-by: default avatarPhil Elwell <>
Signed-off-by: default avatarDavid S. Miller <>
Signed-off-by: default avatarSasha Levin <>
parent f18ed65d
......@@ -2508,10 +2508,6 @@ static int lan78xx_open(struct net_device *net)
if (ret < 0)
goto out;
ret = lan78xx_reset(dev);
if (ret < 0)
goto done;
netif_dbg(dev, ifup, dev->net, "phy initialised successfully");
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment