Commit fd7f6727 authored by Jean Delvare's avatar Jean Delvare Committed by Herbert Xu

crypto: crc32c - Fix crc32c soft dependency

I don't think it makes sense for a module to have a soft dependency
on itself. This seems quite cyclic by nature and I can't see what
purpose it could serve.

OTOH libcrc32c calls crypto_alloc_shash("crc32c", 0, 0) so it pretty
much assumes that some incarnation of the "crc32c" hash algorithm has
been loaded. Therefore it makes sense to have the soft dependency
there (as crc-t10dif does.)

Cc: Tim Chen <>
Cc: "David S. Miller" <>
Signed-off-by: default avatarJean Delvare <>
Signed-off-by: default avatarHerbert Xu <>
parent 4f0414e5
......@@ -172,4 +172,3 @@ MODULE_DESCRIPTION("CRC32c (Castagnoli) calculations wrapper for lib/crc32c");
MODULE_SOFTDEP("pre: crc32c");
......@@ -74,3 +74,4 @@ module_exit(libcrc32c_mod_fini);
MODULE_AUTHOR("Clay Haapala <>");
MODULE_DESCRIPTION("CRC32c (Castagnoli) calculations");
MODULE_SOFTDEP("pre: crc32c");
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment