Commit aa7d01fd authored by Julia Lawall's avatar Julia Lawall Committed by Mauro Carvalho Chehab

media: v4l2-pci-skeleton: constify vb2_ops structures

These vb2_ops structures are only stored in the ops field of a
vb2_queue structure, which is declared as const.  Thus the vb2_ops
structures themselves can be const.

Done with the help of Coccinelle.

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
static struct vb2_ops i@p = { ... };

identifier r.i;
struct vb2_queue e;
position p;
e.ops = &i@p;

position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;

@depends on !bad disable optional_qualifier@
identifier r.i;
 struct vb2_ops i = { ... };
// </smpl>
Signed-off-by: default avatarJulia Lawall <>
Signed-off-by: default avatarHans Verkuil <>
Signed-off-by: default avatarMauro Carvalho Chehab <>
parent 4d7be605
......@@ -282,7 +282,7 @@ static void stop_streaming(struct vb2_queue *vq)
* vb2_ops_wait_prepare/finish helper functions. If q->lock would be NULL,
* then this driver would have to provide these ops.
static struct vb2_ops skel_qops = {
static const struct vb2_ops skel_qops = {
.queue_setup = queue_setup,
.buf_prepare = buffer_prepare,
.buf_queue = buffer_queue,
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment